-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve robustness of device initialization on disconnect/reconnect #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kmontag
commented
Dec 17, 2024
•
edited
Loading
edited
- cleans up startup logic for more predictable device initialization
- suppresses stray CCs which would otherwise be sent at startup and/or when switching to standalone modes
- adds tests for disconnect/reconnect events and other device init scenarios
- updates application python version to 3.11, following Live 12.1
Live's internal MIDI batching was causing sysex messages (i.e. to transition back to hosted mode) to be sent before the background mode program change.
Also update the test framework to validate received messages more aggressively.
Adds `hardware.standalone = False` (if necessary) as part of the mode definition for user-facing modes.
- adds an unmanaged (`None`) state for the device standalone status, and set it when the device is in disabled mode - always pass through disabled mode when receiving an identity response from the controller (avoids potential failures to update devices that were quickly disconnected and reconnected) - when entering standalone modes, only send the standalone sysex if standalone mode isn't already enabled
- More improvements to stabilization logic (add a separate initial vs stability delay) - Respond to multiple identity requests from Live
- Add a `Device` class which manages the active mido I/O port - Remove `loop` fixture and migrate to more native async methods - Add `janus` for the thread-safe asyncio queue, replacing the manual poll approach - Various cleanup for the internal test API
The timeout behavior was needlessly complicated given the device always needs to be fully reinitialized (i.e. sent through standalone init mode) on port changes (since we don't know which ports are changing), defeating the purpose of trying to keep it responsive when other devices are connected/disconnected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.